Use os.TempDir() for test socket path#1694
Merged
Merged
Conversation
Refactor newTestMigrationContext to set ServeSocketFile via os.TempDir() and remove runtime.Caller-based path derivation.
meiji163
approved these changes
May 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces the runtime.Caller(0)-based source-relative socket path with os.TempDir() for the test migration context, avoiding the 108-char Unix socket path limit hit in some CI environments and removing the runtime import and //nolint:dogsled suppression.
Changes:
- Switch
ServeSocketFileconstruction tofilepath.Join(os.TempDir(), "gh-ost.sock"). - Drop the
runtimeimport and the associated//nolint:dogsleddirective.
Show a summary per file
| File | Description |
|---|---|
| go/logic/test_utils.go | Builds test socket path under the system temp dir instead of relative to the source file. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
runtime.Caller(0)-based socket path construction withos.TempDir()innewTestMigrationContext.As the path is constructed relative to the source tree, in some CI environments the path might be too long, causing tests to fail due to the fact that Linux enforces a hard limit of 108 characters for Unix socket paths.
This also ensures that each test run no longer shares a hardcoded socket path, reducing the risk of failures if a previous test leaked the socket.
As an additional benefit, it drops the
runtimeimport and the//nolint:dogsledsuppression.script/cibuildreturns with no formatting errors, build errors or unit test errors.